search

epfl-lts2 / pygsp

Graph Signal Processing in Python
https://pygsp.rtfd.io
BSD 3-Clause "New" or "Revised" License
483 stars 93 forks source link

doc/tutorials/demo.rst typo #5

Closed dsacc closed 7 years ago

dsacc commented 7 years ago

demo.rst says:

You can now access the eigenvalues of the fourier basis with G.e and the eigenvectors G.U, they look like sinuses on the graph. Let's plot the second and third eigenvector, as the one is only constant.

But then, since the index starts at 0, it plots the third and the fourth ones:

pygsp.plotting.plt_plot_signal(G, G.U[:, 2], savefig=True, vertex_size=50, plot_name='doc/tutorials/img/logo_second_eigenvector')
pygsp.plotting.plt_plot_signal(G, G.U[:, 3], savefig=True, vertex_size=50, plot_name='doc/tutorials/img/logo_third_eigenvector')
mdeff commented 7 years ago

Indeed. It's a left-over from the matlab port. Thanks for pointing it out. :) Fixed by 2729440e559b62dd91a06d2b3e43c4c2b84530de.

dsacc commented 7 years ago

Also, at the end of the file there is a not working reference:

 So here are the basics for the PyGSP toolbox, if you want more informations you can check the doc in :ref:`the reference guide section <reference-guide>`.

Have a nice day :+1:

mdeff commented 7 years ago

The link is working on the website though. Am I missing something?

dsacc commented 7 years ago

Probably it was my mistake since it seems to work fine. Sorry for disturbing!

mdeff commented 7 years ago

No problem. Thanks for your help :)