`min_deg` argument of Community class doesn't work?

epfl-lts2 / pygsp

Graph Signal Processing in Python

https://pygsp.rtfd.io

BSD 3-Clause "New" or "Revised" License

488 stars 93 forks source link

`min_deg` argument of Community class doesn't work? #86

Closed mnagaa closed 1 year ago

mnagaa commented 4 years ago

A question.

I want to choose the degree of Community graph. I tried to specify the value, but the min_deg argument is not used in the init function.

If someone knows about this, please tell me.

https://github.com/epfl-lts2/pygsp/blob/b7ca37c0f0eac7bb34167b6a7be0d2d5dbde7662/pygsp/graphs/community.py#L65

https://github.com/epfl-lts2/pygsp/blob/ff8c0023c25df4cbcfd88a7ef63c6223f3030a51/pygsp/graphs/community.py#L65

nperraud commented 4 years ago

It is not implemented. I guess we had some big plans at some point... We can add this option, but the question is what should be the expected behavior.

Add random connections such that the minimum degree is satisfied?
Add community connections such that the minimum degree is satisfied?

This would break the word and community density...