search

epfl-lts2 / pygsp

Graph Signal Processing in Python
https://pygsp.rtfd.io
BSD 3-Clause "New" or "Revised" License
483 stars 93 forks source link

tests should fail for good reasons only #92

Closed mdeff closed 3 years ago

mdeff commented 3 years ago

Fixes the following test error that happened far too often.

20201216_055940

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.002%) to 88.594% when pulling 43dc6d57f6631432fccad585504d643a535853a0 on deterministic-reduction-docstring into f6b5a1f8c7a11ac34a72179701123f8bee85e08b on master.

mdeff commented 3 years ago

And that's the key retrieval issue that often pops up as well.

20201218_232005

mdeff commented 3 years ago

Another kind of false test failures is the verification of hyperlinks. But that's pretty useful as hyperlinks tend to break now and then. We could run it without enforcing it to succeed, but I'm not sure whether we'll pay attention to it if it never fails.

http://tulip.labri.fr fails especially often.

20201219_000108

mdeff commented 3 years ago

Newer sphinx will retry failed hyperlinks (to handle rate-limits) in linkcheck https://github.com/sphinx-doc/sphinx/commit/6b90a63f0862f4cbc31621d0daff8f52fde3ee64. That should also help.