epfl-si / elements

Charte graphique Web EPFL
https://epfl-si.github.io/elements
22 stars 12 forks source link

Clean JS for every Atoms #699

Open williambelle opened 11 months ago

williambelle commented 11 months ago
williambelle commented 11 months ago
./node_modules/.bin/eslint assets/components/atoms

elements/assets/components/atoms/drawer/drawer.js
  4:29  warning  Unexpected unnamed function  func-names

elements/assets/components/atoms/popover/popover.js
   4:5  error    Unexpected function expression                             prefer-arrow-callback
   4:5  warning  Unexpected unnamed function                                func-names
  13:1  error    Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

elements/assets/components/atoms/tag/tag-input.js
  9:13  error  Expected parentheses around arrow function argument  arrow-parens

elements/assets/components/atoms/upload/upload.js
   4:48  warning  Unexpected unnamed function                                func-names
   9:13  error    Use object destructuring                                   prefer-destructuring
  13:55  error    Expected parentheses around arrow function argument        arrow-parens
  20:1   error    Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

✖ 9 problems (6 errors, 3 warnings)
  6 errors and 0 warnings potentially fixable with the `--fix` option.
github-actions[bot] commented 11 months ago

Unit Test Results

    1 files      1 suites   0s :stopwatch: 267 tests 265 :heavy_check_mark: 0 :zzz: 0 :x: 2 :fire: 267 runs  263 :heavy_check_mark: 0 :zzz: 2 :x: 2 :fire:

For more details on these errors, see this check.

Results for commit f991ea29.

github-actions[bot] commented 11 months ago

🔎 Download the Backstop report for this pull request (link valid for 90 days):