MC_FAMILIAR_UPDATE and MC_NPC_UPDATE should be renamed for consistency

epfly6 / RepentanceAPIIssueTracker

An unofficial issue tracker for issues with The Binding of Isaac: Repentance's API.

18 stars 1 forks source link

MC_FAMILIAR_UPDATE and MC_NPC_UPDATE should be renamed for consistency #433

Open Foks256 opened 2 years ago

Foks256 commented 2 years ago

I'm not sure why, but these are the only update callbacks that don't have _POST_ in their name. I think it would be better if these were renamed to MC_POST_FAMILIAR_UPDATE and MC_POST_NPC_UPDATE for consistency, and the original names should be kept for compatibility with older mods.

im-tem commented 2 years ago

i can only assume that these dont have pre/post update because they are happening directly at the update? not too sure but arent familiars and npcs the only custom entities that nicalis actually expected modders to add?