search

epfly6 / RepentanceAPIIssueTracker

An unofficial issue tracker for issues with The Binding of Isaac: Repentance's API.
19 stars 1 forks source link

Something like EntityPlayer:GetDamageMultiplier() should be added #491

Open Foks256 opened 2 years ago

Foks256 commented 2 years ago

A function that just returns the current damage multiplier would be very handy.

Foks256 commented 2 years ago

Also it could be divided into two functions for item multipliers and character specific multipliers.

Zamiell commented 2 years ago

there is no such thing as a damage multiplier. damage is calculated on a continuous basis from start to finish. for example, picking up sacred heart after already having magic mushroom does not "change your damage multiplier". it just increases your damage because an additional if statement is evaluated.

oatmealine commented 2 years ago

not quite; read https://bindingofisaacrebirth.fandom.com/wiki/Damage#Damage_Multipliers for more info but the system is quite a bit more complicated than that:

Some items multiply damage rather than simply adding to it. Damage multipliers do not simply multiply the character's damage once; the damage stat is constantly recalculated and the damage multipliers are multiplied with the end result.

Zamiell commented 2 years ago

the wiki's formula does not reflect what the actual C++ code is doing