search

epfly6 / RepentanceAPIIssueTracker

An unofficial issue tracker for issues with The Binding of Isaac: Repentance's API.
18 stars 1 forks source link

Would be nice if hearts were consistent across players.xml and items.xml #538

Open Foks256 opened 1 year ago

Foks256 commented 1 year ago

It's hp, armor, black and broken for players.xml.

It's maxhearts, hearts, soulhearts, blackhearts for items.xml.

I think it would be best to use the items.xml ones for both items.xml and players.xml, since they're way more clear on what they do. While we're at it, there could also be added all the missing hearts types.

How I imagine players.xml and items.xml after those changes:

maxHearts -- adds empty heart containers (1 = one empty heart container) boneHearts -- adds empty bone heart containers (1 = one empty bone heart) hearts -- fills empty heart and bone heart containers with red hearts (1 = half a red heart) rottenHearts -- fills empty heart and bone heart containers with rotten hearts (1 = one rotten heart) soulHearts -- adds soul hearts (1 = half a soul heart) blackHearts -- adds black hearts (1 = half a black heart) goldenHearts -- adds golden hearts (1 = one golden heart) brokenHearts -- adds broken hearts (1 = one broken heart)

eternalHearts -- adds eternal heart (true or 1 = adds a single eternal heart)

namishere commented 1 year ago

Wouldn't this break existing mods?

Foks256 commented 1 year ago

You could probably still keep the old names aswell just for backwards compatibility, but if that wasn't done, then I think it totally would.