epfly6 / RepentanceAPIIssueTracker

An unofficial issue tracker for issues with The Binding of Isaac: Repentance's API.
19 stars 1 forks source link

EffectVariant.PICKUP_GHOST used by Guppy's Eye as a helper for rendering contents of anything showing unexpected behaviours #546

Open MrSeemsGood opened 1 year ago

MrSeemsGood commented 1 year ago

Guppy's Eye hint effects (enumerated as EffectVariant.PICKUP_GHOST) presumably not only stay alive after the chest for which the pickup is shown is opened, but they also... appear out of nowhere and show up even when not needed?

Here's me typing the same command a few times while there's nothing in a room that'd need a content hint from Guppy's Eye: изображение

And here's me spawning blue fires in places where those effects are to highlight them: изображение

Zamiell commented 1 year ago

So first of all, my mod causes crashes with Guppy's Eye trying to render contents of an empty Red Chest (which, in that case, contains a deal teleport) and I've no idea why.

its because you are missing an anm2 property in your entities2.xml file. i recommend using https://github.com/wofsauge/isaac-xml-validator in CI. please close this issue if this fixes your problem.

MrSeemsGood commented 1 year ago

thanks for the help, seems like it worked! although I would rather edit the issue than close it, since, as you can notice, the crash isn't the only problem at hand.