nnSent output fixed - Githubissues

epfml / sent2vec

General purpose unsupervised sentence representations

Other

1.19k stars 256 forks source link

nnSent output fixed #8

Closed Gldkslfmsd closed 7 years ago

Gldkslfmsd commented 7 years ago

nnSent command didn't get any output before because of several programming bugs (wrong index in cmd line parsing, wrong reading of corpus length). I fixed it and tested nnSent on small corpus, cca 15 sentences. There can still be bugs in other commands...

I also slightly changed output format, I like it more this way.

martinjaggi commented 7 years ago

looks good! can you remove the outcommented lines again? (good to print the number of sentences though) and throw an error message when no sentence file is given?

Gldkslfmsd commented 7 years ago

can you remove the outcommented lines again? (good to print the number of sentences though)

I don't know what you mean.

throw an error message when no sentence file is given?

yes, I can, maybe later today

Gldkslfmsd commented 7 years ago

throw an error message when no sentence file is given? yes, I can, maybe later today

Sorry, I don't have time for it.

BTW., greetings from MT Marathon :)

guptaprkhr commented 7 years ago

Hi Martin, the required changes have been done.

martinjaggi commented 7 years ago

thanks a lot!