epfromer / pst-extractor

Extract objects from MS Outlook/Exchange PST files
59 stars 18 forks source link

Dependencies #1

Closed redchair123 closed 6 years ago

redchair123 commented 6 years ago

First off, awesome library!

Looking at the dependencies, some are superfluous and others can be avoided:

// interpret byte array as double
var b = [205, 204, 204, 204, 204, 220, 94, 64]; new Float64Array(new Uint8Array(b).buffer)[0]
// interpret {low, high} signed 32 bit integers as double
var o = {low:0xcccccccd, high:0x405edccc}; new Float64Array(new Int32Array([o.low, o.high]).buffer)[0]
epfromer commented 6 years ago

Great advice, thank you. I'll clean up the code with your suggestions and post a new release.

epfromer commented 6 years ago

I just published v1.3.0 which incorporates all your feedback.

redchair123 commented 6 years ago

rimraf is still in the package.json for 1.3.0. It appears to only be called in the prebuild script, which iirc is not part of the install lifecycle. Shouldn't it be a dev dep instead of a normal dependency?

epfromer commented 6 years ago

Good point - just fixed and issued v1.3.1.

redchair123 commented 6 years ago

Looks good 👍