Closed redchair123 closed 6 years ago
Great advice, thank you. I'll clean up the code with your suggestions and post a new release.
I just published v1.3.0 which incorporates all your feedback.
rimraf
is still in the package.json for 1.3.0
. It appears to only be called in the prebuild
script, which iirc is not part of the install
lifecycle. Shouldn't it be a dev dep instead of a normal dependency?
Good point - just fixed and issued v1.3.1.
Looks good 👍
First off, awesome library!
Looking at the dependencies, some are superfluous and others can be avoided:
rimraf
is not used at allwinston-loggly-bulk
is commented out andwinston-loggly
is not usedfs-ext
you can keep track of the file position explicitly inPSTFile
, since the library never does a seek from the end of the file. This would also avoid the native node module.math-float64-from-bits
you can use a typed array for this: