search

epha / code-rescode

Other
13 stars 10 forks source link

EAN8 does not work? #1

Closed jensolsson closed 10 years ago

jensolsson commented 10 years ago

The following works great with a 13 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean13", "1234567890123");

The following does not work with a 8 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean8", "12345678");

Is there a bug here?

epha commented 10 years ago

Hi Jensolsson

it is not bug. You have to modify the lib/bwipp/index.js to include ean8. We accept pull requests to require the libs on demand.

2013/11/22 jensolsson notifications@github.com

The following works great with a 13 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean13", "1234567890123");

The following does not work with a 8 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean8", "12345678");

Is there a bug here?

— Reply to this email directly or view it on GitHubhttps://github.com/epha/rescode/issues/1 .

Dr. med. Marco Egbring EPha.ch AG Steinbrüchelstrasse 6 8053 Zürich Tel: +41 44 586 4435

jensolsson commented 10 years ago

I now added a way to load specific libs after the require-statement

Kind regards

Jens Olsson

On 22 nov 2013, at 13:33, Marco Egbring notifications@github.com wrote:

Hi Jensolsson

it is not bug. You have to modify the lib/bwipp/index.js to include ean8. We accept pull requests to require the libs on demand.

2013/11/22 jensolsson notifications@github.com

The following works great with a 13 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean13", "1234567890123");

The following does not work with a 8 digit barcode: var rescode = require("rescode"); var data = rescode.create("ean8", "12345678");

Is there a bug here?

— Reply to this email directly or view it on GitHubhttps://github.com/epha/rescode/issues/1 .

Dr. med. Marco Egbring EPha.ch AG Steinbrüchelstrasse 6 8053 Zürich Tel: +41 44 586 4435 — Reply to this email directly or view it on GitHub.

epha commented 10 years ago

https://github.com/epha/rescode/pull/3