ephemeraHQ / converse-app

https://converse.xyz
MIT License
45 stars 4 forks source link

Add missing initial group permissions #32

Closed saulmc closed 2 months ago

saulmc commented 4 months ago
alexrisch commented 4 months ago

This would need to be prioritized on the SDK level, right now all that can be offered is what the UI currently shows

saulmc commented 4 months ago

I thought this was enabled by XIP-47 -- what parts of that have/have not been implemented? /cc @cameronvoell

nmalzieu commented 2 months ago

We don’t have the same permissions settable during group creation than after creation

createGroup takes a single permissionLevel (which sets only the "who can add members" permission) while on an existing group we can update addMemberPermission, groupNamePermission etc separately.

Waiting for an answer on Slack from the SDK team.

Ideally we wait for that feature to be added in the SDK We could also create group then update its permissions immediately but could def be buggy

nmalzieu commented 2 months ago

Blocked by https://github.com/xmtp/libxmtp/issues/907

cameronvoell commented 2 months ago

heads up @nmalzieu @saulmc this should be included as of @xmtp/react-native-sdk version 2.1.0 and later. Tests here show how it works: https://github.com/xmtp/xmtp-react-native/blob/e436b7c7744132a3e9e808ee348779a2df237a9c/example/src/tests/groupPermissionsTests.ts#L521-L643

Basically a new conversations.newGroupCustomPermissions function. let me know if any q's! 🙏