Overlapping Messages when scrolling

ephemeraHQ / converse-app

https://converse.xyz

MIT License

45 stars 4 forks source link

Overlapping Messages when scrolling #333

Open alexrisch opened 3 months ago

saulmc commented 2 months ago

Shopify may be making progress on FlashList, which provides better performance than FlatList but behavior is buggy when cells are different sizes
Lazy loading w/ FlatList is the common approach to this, but it makes jumping to reply messages quite difficult. We would have to drop support on older Android devices for a while, or accept non-performant rendering
WhatsApp and Telegram are doing something amazing here

saulmc commented 2 months ago

Next step: go back to FlatList and note what performance issues we need to look out for.

nmalzieu commented 2 months ago

Just tried Flatlist again, it freezes immediatly in not so big conversations even on iOS for now. I'll need to investigate more!

nmalzieu commented 1 month ago

Last build has fixed overlapping reactions Increased perf might also improve overlapping messages - I don't see issues with latest build but let's check in the next few days There's still the jumpy scroll when scrolling down after scrolling up : there's a fork of FlashList that handles that if we want, or we wait until they integrate it directly in FlashList.

alexrisch commented 1 month ago

I don't believe this is happening any more, happy to reopen if it is

alexrisch commented 1 month ago

Seeing overlapping with 2 images Will need to dig through the cell recycling and see what's going on