search

ephemeraHQ / xmtp-inbox-ios

ARCHIVED: See the README for info about an alternative iOS app you can try.
4 stars 0 forks source link

Bug: WalletConnect flow doesn't choose between apps #41

Open elisealix22 opened 1 year ago

elisealix22 commented 1 year ago

If I have Rainbow, Ledger & MetaMask installed on my device, Rainbow opens the wc URL even though I want to use a different wallet app and there's no way to change between them currently.

elisealix22 commented 1 year ago

I'm going to explore setting up WC v2 first and will report back if that changes anything!

nakajima commented 1 year ago

I gave WC v2 a try in https://github.com/xmtp-labs/xmtp-inbox-ios/pull/47 but I think we'll need to wait on this until MetaMask supports it.

Do we have an idea on how we'd like this to behave? Should we show our own screen offering popular wallet apps and try to allow people to select one of them explicitly instead of relying on whichever wc:// handler iOS gives us first?

elisealix22 commented 1 year ago

@nakajima that's exactly what I was thinking. I think we'll want to create our own modal that allows people to choose between a subset of wallets & then maybe have a fallback WC button as well that uses the wc:// url. Not perfect, but should offer a little more control than what we have today!

m-005 commented 1 year ago

I'm down for a custom modal.

Two worries that aren't blockers:

nakajima commented 1 year ago

cc @darickdang for UI

darickdang commented 1 year ago

Sounds good!

nakajima commented 1 year ago

Update here: Now that we're using RainbowKit, you can choose between apps. Sometimes those apps don't open though…

nakajima commented 1 year ago

OK, I think we might want our own custom modal here, things just haven't been consistent enough using the webview.

m-005 commented 1 year ago

Relates to #3