ephemeralrogue / gauntlet

A discord.js mocking library for running tests against Discord bot development
MIT License
7 stars 1 forks source link

Bumping discord.js version (v13 -> v14) #15

Open pythonmcpi opened 10 months ago

pythonmcpi commented 10 months ago

Current stable release of discord.js: 14.13.0 Current discord.js version gauntlet targets: ^13.0.0

We should update to v14 to keep up with discord.js development. However, I'm not sure if it would be better to update sooner, or once we finish cleaning up the project. discordjs.guide has a list of the breaking changes between d.js v13 and 14, but a lot of it isn't Discord API related so it shouldn't affect gauntlet too much.

ephemeralrogue commented 10 months ago

@pythonmcpi I 1000% support updating to the discord.js v14.

One thing we've been discussing in the Discord server is mocking the Discord API rather than creating mocks through the discord.js library. In either case, we can still make use of the discord.js library vis-a-vis parsing the API calls a la dismock. There are pros and cons to this approach, though the biggest benefit would be that anyone writing a bot in JS/TypeScript would be able to use this library if we went the route of mocking the Discord API: start of the discord thread

ephemeralrogue commented 10 months ago

Some notes on this upgrade. I think this issue is worth prioritizing.

A thorough upgrade here will require resolving breaking changes, and the removal of src/types/patches.ts with all updates being properly implemented across the codebase. A separate issue will address the refactoring of the types file as a whole.