search

ephes / wagtail_srcset

New template tag for sharp wagtail images on high pixel density devices
Other
15 stars 1 forks source link

Does this really require Python 3.8? #1

Closed CVYY39 closed 4 years ago

CVYY39 commented 4 years ago

This looks great and useful. Unfortunately not all hosted providers are updated to Python 3.8. The pyproject.toml here has a Python 3.8 requirement.

In a quick review I didn't see any Python 3.8-specific code being used. Could this be bumped down to 3.7?

Thanks!

ephes commented 4 years ago

Good point. I just wanted to avoid to have to test against different python versions. But this shouldn't be a problem. Bumped it down to 3.6 since f-strings are used. Thanks for pointing this out :).