search

ephracis / appatite

A shiny way to view your projects
GNU General Public License v3.0
1 stars 1 forks source link

Convert ERB files to HAML #113

Closed cgpacifico closed 7 years ago

cgpacifico commented 7 years ago

There were only three files I found with the .html.erb extentsion. I noticed that the majority of your haml file files are ".html.haml", so I used that extension.

The existing tests pass, however I didn't see any existing tests for the 3 (formerly) erb files in spec/views.

I'm sure what test to include only because I'm having trouble finding how these pages are actually used and what their expected behavior is. At present projects_path reroutes to projects/setup if I am logged in, (and the login page if not), and I'm not clear where the devise#registration action is used or how to access the mailer functionality.

If you have hints that you think would help me write the tests I'm more than happy to give it a go.

Thanks for the opportunity. Looking forward to your feedback.

ephracis commented 7 years ago

Looks good. Great job!

ephracis commented 7 years ago

Now you can update your master branch by pulling from upstream (this repo) and delete your feature branch.

Then you're ready to repeat the process. It's that easy! 😄