search

ephraim / lcurse

Python script to have a "curse" compatible client for linux
The Unlicense
51 stars 24 forks source link

Addon partof package #44

Closed samako93 closed 7 years ago

samako93 commented 7 years ago

Here we go this time... hopefully.

I noticed with some addons (Auctioneer specifically) that come with several modules, that the URL generated for updates was incorrect, since it was based off of the addon's title in the .toc file.

For this addon, the .toc has an extra tag called X-Part-Of with the name of the correct full addon.

Listing all of these single modules under one name allows the URL to be generated correctly, and updates all of the single modules since they are packaged together with it.

I've just added a small section that notifies the user that the addon is a bundle, and allows the addon to be updated.

nicdumz commented 7 years ago

Could you perhaps clean your git history? A PR containing a revert is a bit strange ;-)

ephraim commented 7 years ago

Please update your patches to latest lcurse and please provide a PullRequest without a revert in it.

samako93 commented 7 years ago

I thought I did a reset, but turns out I did a revert. All fixed up though. Cheers

ephraim commented 7 years ago

couldn't apply directly as there were merge conflicts. Anyway applied. Thanks.