search

ephraim / lcurse

Python script to have a "curse" compatible client for linux
The Unlicense
51 stars 24 forks source link

Curse URL has changed #58

Open jwhipp opened 6 years ago

jwhipp commented 6 years ago

I noted lcurse stopped being able to find a few add-ons. Going to the curse site, it appears you're now redirected to https://www.curseforge.com/wow/addons/.

Looks like lcurse needs to update the source URL now. Gotta love Curse and their random changes.

makerbeleg commented 6 years ago

I confirm, does not work at all for me

alar77 commented 6 years ago

Worst thing is that the version number is gone from the first page.... I am trying to fix it in my fork and will submit a PR if I succeed

alarofrunetotem commented 6 years ago

pull-request is up. You can get it from my repository (same user of previous comment, I plainehate how github is not smart in managing 2 accounts)

ilu33 commented 6 years ago

Ephraims version is not working anymore so I tried yours, Alar. This is what I get: 

python3 /opt/lcurse-alar/lcurse
Folders Preferences/wowfolder /home/.../.wine/drive_c/Program Files (x86)/World of Warcraft
Traceback (most recent call last):
  File "/opt/lcurse-alar/lcurse", line 44, in <module>
    from modules import application
  File "/opt/lcurse-alar/modules/application.py", line 19, in <module>
    from modules import waitdlg
  File "/opt/lcurse-alar/modules/waitdlg.py", line 15, in <module>
    from cryptography.hazmat.primitives.hashes import MD5
ImportError: No module named 'cryptography'

After some searching I decided to install the package python3-cryptography and now things seem to work. You should note that under dependencies. Thank you for keeping this up-to-date!

alar77 commented 6 years ago

I am glad it works, I didnt add (at least, not willingly) any dependency, had you already installed ephraims version before or you started straight on with mine?

ilu33 commented 6 years ago

I had an older version of Ephraims before. In the version I used there was no cryptography or hash function in waitdlg.py. I think he introduced this sometime ago and made another change recently, see https://github.com/ephraim/lcurse/commit/ef70ea78882fd19d47cd60afdeb98d4d12382ade - but without eliminating the dependency, contrary to what the title says.