ephraim / lcurse

Python script to have a "curse" compatible client for linux
The Unlicense
51 stars 23 forks source link

Curse changed their directory structure - again #75

Open ilu33 opened 5 years ago

ilu33 commented 5 years ago

... Updates don't work anmore (404). They add a (random?) number at the end of the URL.

Nuadh commented 5 years ago

Probably not a good idea, but I've made a (temporary) replacement in perl. Just so I can update my addons without running windows:) Tbh, I would rather use lcurse, but, hey..

https://git.smokepit.net/Nuadh/pcurse

Ps.: I'm sorry I advertise other software here, It's probably not nice.

fbesser commented 5 years ago

Probably not a good idea, but I've made a (temporary) replacement in perl. Just so I can update my addons without running windows:) Tbh, I would rather use lcurse, but, hey..

thank you for your work, but unfortunately it's not working. I get Found Clique(v80000-1.0.0)Could not find product id for Clique for every Addon

Nuadh commented 5 years ago

Could you send me your ~/.lcurse/addons.json, /.pcurse/config.json and ~/.pcurse/addons.json . I'll try to find out what makes it misbehave:)

fbesser commented 5 years ago

Could you send me your ~/.lcurse/addons.json, /.pcurse/config.json and ~/.pcurse/addons.json . I'll try to find out what makes it misbehave:)

here you go

Nuadh commented 5 years ago

My bad, expecting a http Uri, not a HTTPS one:) new version up, please try again:)

fbesser commented 5 years ago

My bad, expecting a http Uri, not a HTTPS one:) new version up, please try again:)

Works great thank you

ilu33 commented 5 years ago

@mboquien has fixed his lcurse fork, until @ephraim pulls in the changes just use his version.

Philmore971 commented 5 years ago

Hi all. I made some changes to waitdlg.py I also used the latest proposed code elements on the main branch Catalogue and addon updates are functional I downloaded my modified version on my fork https://github.com/Philmore971/lcurse Do not use the file directly, there are translations Fr inside the code Sometimes the catalogue update stops before the end (98% 99%) I don’t have an answer Test my version please

ilu33 commented 5 years ago

Curse changes again: Now they are providing versions for wow classic under the same project - see BigWigs, Capping, DBM and probably others too. If I enter https://www.curseforge.com/wow//download in the browser the correct non-classic version gets selected. But lcurse seems to check for the newest version and enters that specific id which might be the classic version, depending on what was most recently updated. At the moment most of those addons have a file name that ends on "-classic". But that's not a given so checking the game version would be necessary.

Any idea how to adapt the code, @mboquien, perhaps?

mboquien commented 5 years ago

@ilu33 My subscription has lapsed and I will likely not go back for at least a couple of month. If nobody has had a look by then, I will dig into it.

Philmore971 commented 5 years ago

we will only have to process the download corresponding to the correct version of Wow. Actually, wow-classic is installed in another directory. Lcurse does not handle several versions of Wow. For the moment, I had no problem with the versions. Wow 8.2 seems to be the default version when downloading ... to check.

fbesser commented 5 years ago

actually it is a problem, it gets the first Release from the list and if the classic version is the last release it installs the classic version. Ran into this with a few addons, like Bigwigs and Details!. Problem is every Addon names their releases different most addons add -classic to the end of the version, easy to filter out with

              while True:
                    print(lis[versionIdx].td.next_sibling.next_sibling.a.string)
                    isOk= beta or lis[versionIdx].td.div.span.string=='R' and not "classic" in lis[versionIdx].td.next_sibling.next_sibling.a.string
                    if isOk:
                        break
                    versionIdx=versionIdx+1

But Details! i.e. just uses total different version number.