search

ephraim / lcurse

Python script to have a "curse" compatible client for linux
The Unlicense
51 stars 23 forks source link

Randomly installs classic versions #79

Open zerodogg opened 5 years ago

zerodogg commented 5 years ago

Using the latest version of lcurse it is randomly chosing to install "classic" versions of mods rather than the live versions. It has done this to, among others, AdvancedInterfaceOptions, DBM Voicepack VEM, Details! Damage Meter, GTFO and Prat 3.0

torkus commented 5 years ago

hi, not a maintainer of lcurse, but the issue lies about here: https://github.com/ephraim/lcurse/blob/4a22aa1607ddce818bf0a4d69f31d5fef160601b/modules/waitdlg.py#L192-L201

it's because curseforge relatively recently allowed 'classic' releases of their addons, as well as alpha/beta/alternate releases that lcurse already seems to do.

This is really bad form on my part, but there are other addon managers that support classic here: https://github.com/ogri-la/wowman#other-addon-managers

timwienk commented 5 years ago

I do have it working in my version, I PR'ed my changes in #80 in case that helps.

timwienk commented 5 years ago

Since #80 is merged, I think this is solved and can be closed.

torkus commented 5 years ago

I've taken a look at the code changes and read the commit messages and I'm still not clear on whether lcurse actually supports the installation of classic addons from curseforge or is just ignoring them ... I ask because my data may be wrong ;)

timwienk commented 5 years ago

It supports Classic as well. It should even work for PTR as well, provided if it's installed in the same WoW directory.