search

ephraim / lcurse

Python script to have a "curse" compatible client for linux
The Unlicense
51 stars 24 forks source link

Addon Folder arent removed when addon is removed from lcurse #9

Closed ephraim closed 7 years ago

ephraim commented 9 years ago

A removed addon of lcurse is still available in wow.

The remove dlg should have the option that lcurse should try to remove it from wow too.

fosspill commented 7 years ago

Hmm, any hints as to how we could go about fixing this? I'm very interested in trying! :)

sunaurus commented 7 years ago

Should be very simple: https://docs.python.org/3/library/shutil.html#shutil.rmtree

But you should be careful - make sure that it's impossible for a wrong path to end up as an argument (don't want users to delete their home directories)

fosspill commented 7 years ago

Fair enough, I was more thinking about how we should include it in the code (what file would it belong in, for instance)

sunaurus commented 7 years ago

I think you could just expand the existing removeAddon method here: https://github.com/ephraim/lcurse/blob/master/modules/application.py#L344