epi-project / brane

Programmable Orchestration of Applications and Networking
Apache License 2.0
9 stars 7 forks source link

Added proto3 optional flag for `protoc` custom build in `brane-tsk` #34

Closed marinoandrea closed 1 year ago

marinoandrea commented 1 year ago
Lut99 commented 1 year ago

Wow, thanks :)

However, I should have told you yesterday - the develop branch holds the latest changes, and in theory I should have removed the protobuf compiler (protoc) dependency altogether. Although this would probably fix the dependency issue on Debian-based distros (which ship with a protoc compiler that requires this change), I'd rather avoid this extra dependency if I can. Moreover, because I only use these protobuf definitions for inter-Rust communication, it's more practical to define them in Rust directly so we can simply tag existing structs instead of re-defining them in protobuf.

Let me know if you get the same error in the develop branch, or, alternatively, let me bring the main branch up-to-date and test it myself. If the issue persists we can merge this issue, or otherwise I think I'll close it :# But thanks a lot for you work, though!

marinoandrea commented 1 year ago

I see, will close the PR then.