Closed devx00 closed 7 months ago
i ran a few tests and can't repro the issue. Are you able to consistently trigger this bug?
i ran a few tests and can't repro the issue. Are you able to consistently trigger this bug?
Ya I can consistently reproduce it with very specific steps. My original repro steps weren't enough to reproduce it though. I think the issue may only arise under some specific circumstances.
I'll edit my repro steps to include the specific steps I took but I am not even sure the steps alone are enough to reproduce it. For all I know the response of the specific target may be involved as well since so far I have only reproduced it with the exact scan parameters and actions as when I initially experienced the bug.
Nice! If the responses matter, and you're able to, capture them and strip out any sensitive info. We can mock up a server with them
i may have stumbled across this today and fixed it. I'll link the PR for testing once it's up.
give this branch a try with your configs and see if we caught it
https://github.com/epi052/feroxbuster/pull/1035
the fix is in event_handlers/outputs.rs
if this doesn't fix what you're seeing, we should probably audit event handlers for cases where a ?
is causing the handler's thread to exit prematurely.
@devx00 just checking back to see if you had a chance to try this
@devx00 just checking back to see if you had a chance to try this
Oh man somehow I missed all those other comments. I have not had a chance to test it. I might have some time in a little bit to pull the branch and test it against the same target it was using before. Hopefully I described it well enough for me to repro it following my own instructions.
@devx00 it's no problem at all. that branch was merged, you can just give it a shot from main. thank you (also, no hurry)!
closing this one as fixed. if that's not the case, feel free to reopen
@all-contributors add @devx00 for bugs
@epi052
@devx00 already contributed before to bug
thought so, good bot
Describe the bug Feroxbuster will exit early despite some jobs still being in process. It appears to happen when the remaining jobs were all added manually through the in-scan management menu.
To Reproduce Steps to reproduce the behavior:
Expected behavior The scan should have finished all jobs.
Environment (please complete the following information):
Update
Additional Info:
--dont-extract-links
is set.