epi052 / feroxbuster

A fast, simple, recursive content discovery tool written in Rust.
https://epi052.github.io/feroxbuster/
MIT License
5.61k stars 472 forks source link

Small screen width leads to repeating lines in output #1038

Closed watskenet closed 4 months ago

watskenet commented 7 months ago

if my screen size small , show to me wrong data in screen

Pharisee commented 7 months ago

Instead of opening a new issue, I'll just expand on this one since (if it's not just a troll) there's a chance it's related.

Essentially when the window is small enough that the length of one of the lines exceeds it, the output bugs out and starts repeating lines and scrolling down the screen endlessly in a real ugly way. My guess is it seems like a problem with however the output lines are being updated/refreshed that doesn't like when the lines go past the far edge of the terminal window and are forced to wrap.

Dunno rust shit, so no clue where the issue is or if it's fixable, but figured I'd drop it in here since it was bugging me trying to figure out why the output looked like trash when everybody was saying it looked dope until I figured out I just needed to widen the window. Anyways, it's quality shit dude. Appreciate ya.

image

epi052 commented 7 months ago

tysm! glad you're enjoying it

as for the output, this has been a known issue for a very long time. I use a library for handling terminal output and don't plan on trying to apply a fix for this particular issue. The workarounds are documented at the link below:

https://epi052.github.io/feroxbuster-docs/docs/faq/progress-bars/

i think the only reasonable fix is to check terminal width at startup and emit a warning to the user :thinking:

epi052 commented 5 months ago

morning! i was going to add a warning on small terminal width, but i can't actually reproduce this anymore. could you give it a shot and see if you can still get it to do this @Pharisee

Pharisee commented 5 months ago

Ah. Sorry, I didn't respond before. Been a busy year so far. Just tested it again and it seems like the bug is only triggering in t-pain mode (aka --auto-tune) when the stoplight message displays (set rate limit, increased scan speed, etc.)

epi052 commented 4 months ago

thanks for that! What terminal are you using? i've tried 3 separate terminal emulators and still can't repro, even with auto-tune.

all i really need to know is the terminal width at which i should warn users that things may get wonky. i could just say 80 or less and call it a day, but would like to be more specific. any chance you could get that info @Pharisee ?

Pharisee commented 4 months ago

Hmm, I wonder what's diifferent. I've been able to replicate it consistently with qTerminal, kitty, and alacritty. It's hard to say a specific width since it's just happening any time one of the directory listing lines at the bottom reaches the width of the terminal.

epi052 commented 4 months ago

no worries, it sounds like there's not an easy static value with which we can warn folks. in that case, going to skip the warning and let current documentation/issues stand as-is.

Thank you for your help with this!