epi052 / feroxbuster

A fast, simple, recursive content discovery tool written in Rust.
https://epi052.github.io/feroxbuster/
MIT License
5.61k stars 472 forks source link

[BUG] error: thread 'tokio-runtime-worker' panicked at .../into_url.rs a parsed Url should always be a valid Uri: InvalidUri(TooLong) #1049

Closed dirhamgithub closed 4 months ago

dirhamgithub commented 6 months ago

This error is facing me after i have provided the url and word list it finds for me some hidden pages and then it throws me this error, I don't know if the websites made this url to prevent from finding thier hidden files or it is just from Feroxbuster tool. Here is a screenshot of the error:

feroxbuster

epi052 commented 6 months ago

sorry for the late reply, didn't see this one.

that looks to be coming from a library that ferox relies on to do url parsing. at best, id be able to check to make sure we don't trigger the underlying core dump...

thanks for the bug report! ill take a look at a fix

epi052 commented 6 months ago

ok, following up on this: the underlying library has a pull request to turn this panic into an Error. Once that lands, i can make sure i handle the Error (it may already be handled cleanly, if not ill update).

for anyone wondering, the max URI length is u16::MAX or 65,535. In the meantime @dirhamgithub you can use --dont-scan to prevent that particular folder from being scanned OR if the url is being picked up during link extraction, you can try --dont-extract-links. Happy hunting!

pinning this til i get an upstream fix

amiremami commented 5 months ago

Hey, thanks for the interesting tool. I installed feroxbuster for the first time today. I tried it on 3 different domains, and for all of them I got the error. It seems feroxbuster is not functional at the moment, am I right?

image

epi052 commented 5 months ago

@amiremami no, that's not correct. you're encountering what i consider an edge case. that you found it on three separate targets is pretty impressive to me, lol. parsing a url over 65,535 characters is not what i would consider the norm.

at any rate, thank you for pinging this thread. the upstream fix was merged and i can push a fix for this on my end. expect an update soon!

epi052 commented 4 months ago

@all-contributors add @amiremami and @dirhamgithub for bug

allcontributors[bot] commented 4 months ago

@epi052

I've put up a pull request to add @amiremami! :tada:

epi052 commented 4 months ago

https://github.com/all-contributors add @dirhamgithub for bug

epi052 commented 4 months ago

@all-contributors add @dirhamgithub for bug

allcontributors[bot] commented 4 months ago

@epi052

I've put up a pull request to add @dirhamgithub! :tada:

epi052 commented 4 months ago

fixed in main, new release soon

amiremami commented 4 months ago

fixed in main, new release soon

Thanks a lot, it works now 🙏