Closed rrdavis77 closed 10 months ago
Hi @rrdavis77, thanks for highlighting the issue. We are aware of the problem with numerical sample names and its on our list of updates for the workflow.
Can you please not close issues unless they are fixed? It makes it a bit difficult to find related issues when we git errors, and it will stop duplicate issue posts.
Could I also please ask if there's been any fix for this?
In the process of updating the pipeline to the latest version I have come across this bug. Unfortunately the unique IDs we use are all numbers. This bug persists all the way from version 3.24 to 3.33.
My apologies for bugging @cjalder but it's really a huge issue for us currently.
Apologies @ammaraziz - Like stated above the work is on our forecast for future work. I will see if it can be expedited.
Thank you @cjalder for your understanding.
I have identified the issue and will submit a pull request.
Thanks again,
Ammar
Operating System
Ubuntu 22.04
Other Linux
No response
Workflow Version
v0.3.32
Workflow Execution
Command line
EPI2ME Version
No response
CLI command run
NXF_VER=23.04.2 nextflow run epi2me-labs/wf-artic --fastq /home/ryan/NGS_Data/Promethion_data/ --report_depth 20 --scheme_name SARS-CoV-2 --scheme_version Midnight-ONT/V3 --out_dir /home/ryan/NGS_Data/midnight_test_run/wf-artic-results_72hr_correct_medaka2/ --sample_sheet samplesheet_nanopore_wf-artic-10-29-23.csv -w /home/ryan/NGS_Data/midnight_test_run/wf-artic-results_72hrcorrect_medaka2/workspace --medaka_variant_model r1041_e82_400bps_sup_variant_g615 -resume --update_data false --artic_threads 15 -c config_wfartic.cfg --basecaller_cfg dna_r10.4.1_e8.2_400bps_sup@v3.5.2
Workflow Execution - CLI Execution Profile
standard (default)
What happened?
The entire pipeline will run succesfully until it tries to generate the final html report. Most of my sample names are only digits. And it throws an error such as:
ValueError: failed to validate Panel(id='1130', ...).title: expected a value of type str, got 500125050 of type int64
If I add a string of text to my sample names then the pipeline completes succesfully. This error will most likely only happen with sample names that are digits.
Relevant log output
Application activity log entry
No response