epi2me-labs / wf-artic

ARTIC SARS-CoV-2 workflow and reporting
https://labs.epi2me.io/
Other
47 stars 34 forks source link

Fix HTML report output errors on int sample_names #106

Closed ammaraziz closed 3 months ago

ammaraziz commented 7 months ago

This pull fixes #101.

If the sample sheet contains only numeric values for the sample_name the reporting step fails. This happens due to bokeh function Panel expecting a str. In addition, the summary_fn dataframe needs to also have a data type of str for sample_name

Thanks,

Ammar

cjalder commented 7 months ago

Hi @ammaraziz. Thanks for the pull request, we will put this in our internal system and hopefully add it to the next release cycle.