epi2me-labs / wf-artic

ARTIC SARS-CoV-2 workflow and reporting
https://labs.epi2me.io/
Other
49 stars 36 forks source link

Adding support for dna_r10.4.1_e8.2_400bps_sup@v4.2.0 #95

Open llk578496 opened 1 year ago

llk578496 commented 1 year ago

Is your feature related to a problem?

The latest supporting model for --basecaller_cfg is dna_r10.4.1_e8.2_400bps_sup@v3.5.2.

Describe the solution you'd like

Is it possible to add the model dna_r10.4.1_e8.2_400bps_sup@v4.2.0 in the --basecaller_cfg? Thanks a lot.

Describe alternatives you've considered

-

Additional context

No response

cjw85 commented 1 year ago

Hi @llk578496,

This is on our TODO list.

ammaraziz commented 6 months ago

I am getting a related issue. @cjw85 could please explain where the models are being retrieved from? The docker image of medaka or somewhere else? I am recieving this #104 error again. Trying to debug where/what is happening.

The model I am trying to run is dna_r10.4.1_e8.2_400bps_hac@v3.5.2 and also dna_r10.4.1_e8.2_400bps_hac

cjw85 commented 5 months ago

@mattdmem

ammaraziz commented 4 months ago

@cjw85 @mattdmem Sorry to bug you guys, we've switched over to r10 but I'm struggling to get the pipeline to use the medaka r10 models. We're running the docker images in such a way that they can't access the internet.

I think I have identified the issue, the wf-artic docker image comes with only r941_min_hac_g507_model.tar.gz model.

Could the docker image please be updated to include r10 which is standard now?

Using the latest docker image:

docker run -it ontresearch/wf-artic:latest medaka tools resolve_model
/home/epi2melabs/conda/lib/python3.8/site-packages/medaka/data/r941_min_hac_g507_model.tar.gz

using the 7month old one specified in the nextflow config:

docker run -it ontresearch/wf-artic:sha6e8c02f120faf92b4e61e1d0797d71210aaec20b medaka tools resolve_model
/home/epi2melabs/conda/lib/python3.8/site-packages/medaka/data/r941_min_hac_g507_model.tar.gz
julibeg commented 3 months ago

Hi @llk578496 and @ammaraziz, the workflow and image have been updated. Could you please confirm if this fixes the issue? Thanks!

ammaraziz commented 3 months ago

Will test out this week or next. Thanks Julibeg!