search

epibook / epibook.github.io

Publishes to Github Pages
335 stars 238 forks source link

Move interrupt() out of try_catch for better readability. #22

Closed skanagavelu closed 8 years ago

skanagavelu commented 8 years ago

Since interrupt() wont throw any checked exception; moving out of try/catch. And now it will be more clear that InterruptedException got at innerThread due to this interrupt() call.

epibook commented 8 years ago

hi kanagevalu,

thanks for your report, i have merged the PR.

on a semi-related note, we have been looking through the concurrency chapter recently, looking for ways in which we can better explain solutions, also possibly add/remove a couple of problems.

we'd be very happy to hear your suggetsions, also if you could take a look at some of the updates we were planning. even 45 mins of your time would be valuable.

bye, adnan

ps - we are also trying to make C++ versions of the programs, do you have experience with concurrency in C++?

On Fri, Nov 20, 2015 at 6:05 AM, Kanagavelu Sugumar < notifications@github.com> wrote:

Since interrupt() wont throw any checked exception; moving out of try/catch. And now it will be more clear that InterruptedException got at

innerThread due to this interrupt() call.

You can view, comment on, or merge this pull request online at:

https://github.com/epibook/epibook.github.io/pull/22 Commit Summary

  • Move interrupt() out of try_catch for better readability.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/epibook/epibook.github.io/pull/22.

skanagavelu commented 8 years ago

Hi Adnan,

It is my pleasure. I will do that.

Thanks, Kanagavelu Sugumar.

PS- Sorry, I don't have experience on C++; However do have good knowledge on java and can contributing over here .