search

epic-astronomy / LWA_EPIC

The LWA-specific implementation of the EPIC correlator
http://livetv.epic-astronomy.org
MIT License
3 stars 3 forks source link

Numpy speedups #32

Closed adampbeardsley closed 3 years ago

adampbeardsley commented 3 years ago

Should this be merged in?

mkolopanis commented 3 years ago

ah yeah I was working on this, but wanted to get something else in first I remember. Let me get going on this again.

mkolopanis commented 3 years ago

Here's the jupyter notebook i used to develop/test these changes. While there are some speed ups which is nice, there's a considerable reduction in the memory bloat in a lot of these functions too.

numpize_for_loops.pdf

mkolopanis commented 3 years ago

I think at this point we might as well get this reviewed and in/out and then we can come back from another wave of changes later if we need them.

adampbeardsley commented 3 years ago

Looks great, thanks @mkolopanis . Unfortunately, I can't approve the PR since I'm the one who opened it.