search

epic-kitchens / C1-Action-Recognition-TSN-TRN-TSM

EPIC-Kitchens-100 Action Recognition baselines: TSN, TRN, TSM
Other
31 stars 19 forks source link

Horizontal flip not returning flipped images? #20

Closed kiyoon closed 2 years ago

kiyoon commented 2 years ago

https://github.com/epic-kitchens/C1-Action-Recognition-TSN-TRN-TSM/blob/2b7fa1894656e71dc5f8935213396b12c01b2eef/src/transforms.py#L60-L76

It looks like ret is never returned, but instead the original images are returned. Can you check if the code may be not applying flip at all?

Additionally, is_flow in the __call__ method seems to be never used.

DWhettam commented 2 years ago

Hi @kiyoon, thanks for pointing that out! I believe you are correct. We use transforms from the TSN codebase, which had the same issue, although now seem to have been fixed.

I'll update the code and test it all works, but for now you should be able to replace the function with the version in the TSN codebase.

DWhettam commented 2 years ago

Fixed via #21, closing this issue

kiyoon commented 2 years ago

Thanks for the prompt update!

You can also remove the is_flow in the __call__ method which does nothing and just creates more confusion. That has to be defined in __init__ instead.