epic-open-source / seismometer

AI model evaluation with a focus on healthcare

https://epic-open-source.github.io/seismometer/

BSD 3-Clause "New" or "Revised" License

179 stars 21 forks source link

Update data load pattern to be extensible #30

Closed diehlbw closed 3 months ago

diehlbw commented 3 months ago

Overview

Closes #20

Description of changes

Pulled the loading logic for prediction and event data out of the Seismogram class

[ ] Should maintain functionality for loading from parquet
[ ] Existing example notebook should work unchanged (ie Verify run_startup works as is)
[ ] Verify that loading is also possible from preloaded dataframes. If using the example notebook make sure that the files don't also exist and update run_startup cell to pass in the loaded dataframes.

Note: Updates to allow loading from urls will be done in a follow-up PR

Author Checklist

[x] Linting passes; run early with pre-commit hook.
[x] Tests added for new code and issue being fixed.
[ ] Added type annotations and full numpy-style docstrings for new methods.
[ ] Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.