epic-power-rpg / roll20

Apache License 2.0
0 stars 0 forks source link

Add a button to pre-generate the character skills #100

Closed jazeee closed 7 months ago

jazeee commented 8 months ago

All characters have a baseline of skills. Often, people's character sheets drift from this, and that can break things like defense calculations. This also helps DM's create new characters and monsters.

Also added a confirmation popover

image image

jazeee commented 7 months ago

I wonder if the simple fix is to only show the button when there are no skills.

johnlamping commented 7 months ago

That sounds like a great solution.

On Wed, Feb 21, 2024 at 8:29 PM Jaz @.***> wrote:

I wonder if the simple fix is to only show the button when there are no skills.

— Reply to this email directly, view it on GitHub https://github.com/epic-power-rpg/roll20/pull/100#issuecomment-1958679439, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTV55T7JD2X3A2VWDM4SPLYU3CQZAVCNFSM6AAAAABDOUWTESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJYGY3TSNBTHE . You are receiving this because your review was requested.Message ID: @.***>

johnlamping commented 7 months ago

And it would be easily extendable to generate different kinds of base characters. It would be fine to take lots of screen real estate, since it would only show up when making a new character.

On Wed, Feb 21, 2024 at 8:50 PM John Lamping @.***> wrote:

That sounds like a great solution.

On Wed, Feb 21, 2024 at 8:29 PM Jaz @.***> wrote:

I wonder if the simple fix is to only show the button when there are no skills.

— Reply to this email directly, view it on GitHub https://github.com/epic-power-rpg/roll20/pull/100#issuecomment-1958679439, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTV55T7JD2X3A2VWDM4SPLYU3CQZAVCNFSM6AAAAABDOUWTESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJYGY3TSNBTHE . You are receiving this because your review was requested.Message ID: @.***>

jazeee commented 7 months ago

I couldn't figure out how to hide the button if there are already skills in the repeating list. I did get the confirmation popover in place.