search

epic-power-rpg / roll20

Apache License 2.0
0 stars 0 forks source link

Add character effectiveness #113

Closed johnlamping closed 3 months ago

johnlamping commented 4 months ago

Add the calculation of effectiveness to the character sheet. Also do some clean up of names.

johnlamping commented 4 months ago

There is currently a bug somewhere that is causing the new character stuff to not fire, while giving an error that a formula can't find a value for FP. (I had only been testing on existing characters.) I'm in the middle of a binary search of the commits to see where I introduced it.

johnlamping commented 4 months ago

The last commit fixed the bug mentioned above. The problem was that I had simplified updates by having them no longer call other updates. Instead, each update's trigger is responsible for everything the update depends on. But I had forgotten to update the trigger for updateUser to include sheet:opened.

johnlamping commented 3 months ago

Thanks! I think it's ready for one more look now.