epic-power-rpg / roll20

Apache License 2.0
0 stars 0 forks source link

The spell fields don't line up with their headers #19

Closed johnlamping closed 1 year ago

johnlamping commented 1 year ago

This code shrinks many of the spell fields by one: .spell-row>input~input, .spell-row>input~select, .spell-row>select~input { / Make consecutive buttons overlap / margin-left: -1px; }

But there is nothing comparable for the table headers. The answer is probably to add a new selector: .input-header, which headers for inputs or select get, and then add .input-header~.input-header { / Shrink to correspond to the consecutive buttons overlap / margin-left: -1px; }

jazeee commented 1 year ago

The margin-left -1px makes things complicated. Instead, I think we should look at other options. One option is to simply remove them, as seen in #23

jazeee commented 1 year ago

I have an alternative - using display: grid: image

jazeee commented 1 year ago

Example: https://github.com/epic-power-rpg/roll20/pull/24

jazeee commented 1 year ago

I believe this issue is now resolved.