Rework Parry fields

[jazeee]

The problem is that it needs to know what the parry bonus of your weapon is, and that isn't currently recorded on the character sheet. I can think of a couple of options:

• Add a new field to weapons, giving their parry bonus; then use the highest bonus as the bonus for parry.
• Add a new field to the defense block where you can fill in the Parry bonus. I don't see a nice place for it, though.

If the Parry row had "--" values if you ha no weapon with a parry bonus.

Originally posted by @johnlamping in https://github.com/epic-power-rpg/roll20/issues/35#issuecomment-1384362920

[johnlamping]

It would make sense for the new weapon field to be titled "Def.", like the fields for armor and shield. That would make things relatively consistent. And, with my wishes turning into code so fast, Jaz ... Giving the Def. headers an explanatory popover would be a nice touch. They would say something, "Amount added to all defenses" "Amount added to Block defense", "Amount added to Parry defense", respectively

[jazeee]

I'm going to take a look at this now. (sorry about the delay lol)

[jazeee]

[jazeee]

@johnlamping - is the parry calculated as weapon parry + armor? In other words, is there parry with armor and parry without armor?

[johnlamping]

Yes. The normal calculation is weapon parry + defense ability + armor, and the no armor calculation is weapon parry + defense ability. BTW, I'd suggest putting the Def. field first, so it is the first field for armor, shield, and weapons.

On Sat, Jan 21, 2023 at 5:21 PM Jaz @.***> wrote:

@johnlamping https://github.com/johnlamping - is the parry calculated as weapon parry + armor? In other words, is there parry with armor and parry without armor?

— Reply to this email directly, view it on GitHub https://github.com/epic-power-rpg/roll20/issues/69#issuecomment-1399375808, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTV55SPFGOKL3IQAPRDESDWTSDRFANCNFSM6AAAAAAT5JHOPE . You are receiving this because you were mentioned.Message ID: @.***>

[jazeee]

Sure. I was just thinking that the weapon is primarily used for attack, hence damage range def. Easy enough to move it though.

[johnlamping]

Good point. In fact, since you point that out, it seems like Damage and Range should come first for weapons, followed by Def., then the rest of the stuff. I must not have been thinking when I put them where they are.

On Sat, Jan 21, 2023 at 5:38 PM Jaz @.***> wrote:

Sure. I was just thinking that the weapon is primarily used for attack, hence damage range def. Easy enough to move it though.

— Reply to this email directly, view it on GitHub https://github.com/epic-power-rpg/roll20/issues/69#issuecomment-1399380770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTV55SXSOZM7HPTHJAVGOTWTSFTBANCNFSM6AAAAAAT5JHOPE . You are receiving this because you were mentioned.Message ID: @.***>

[jazeee]

Got the columns in place. Separately, I'll update the parry section https://github.com/epic-power-rpg/roll20/pull/70

[jazeee]

Ok, got the calculation code working. PR coming

[jazeee]