epicentre-msf / covid19

Epicentre's covid-19 data analysis and visualisation
https://reports.msf.net/public/covid19/
7 stars 2 forks source link

Table and plots initial optimization. #2

Closed krystian8207 closed 4 years ago

krystian8207 commented 4 years ago

This is Appsilon's initial approach to app optimization.

What has changed:

Here you can see the final result: output

PaulC91 commented 4 years ago

Hi Krystian. This is great, thanks a lot.

A 4 second improvement by switching to JS on expand rows is very interesting!

The only issue I can see is that the labels on the highcharts date axis are not formatted as dates anymore. Ready for a merge if we can fix this!

Thanks again, Paul

krystian8207 commented 4 years ago

@PaulC91 let me take a look at axis labels issue. Could you provide which packages versions do you use in the application? renv.lock or manifest.json file would be very helpful here.

About using JS on rows expanding, please verify if the default message when no comments are available in the data is correct from the UX perspective and meet your expectations.

krystian8207 commented 4 years ago

@PaulC91 I pushed one commit with fixing the labels. ptal

PaulC91 commented 4 years ago

I've added a renv.lock to the master branch.

Date axis labels appear to be fixed but there's an issue with the daily cases/death chart now:

Screenshot 2020-05-26 at 14 59 29

krystian8207 commented 4 years ago

@PaulC91 Thank you for spotting that. This would work fine now.

PaulC91 commented 4 years ago

Yes looking good! thanks. Can we go with "No further information available" the default table expand message?

krystian8207 commented 4 years ago

Sure, changed already.