Closed krystian8207 closed 4 years ago
Hi Krystian. This is great, thanks a lot.
A 4 second improvement by switching to JS on expand rows is very interesting!
The only issue I can see is that the labels on the highcharts date axis are not formatted as dates anymore. Ready for a merge if we can fix this!
Thanks again, Paul
@PaulC91 let me take a look at axis labels issue. Could you provide which packages versions do you use in the application? renv.lock
or manifest.json
file would be very helpful here.
About using JS on rows expanding, please verify if the default message when no comments are available in the data is correct from the UX perspective and meet your expectations.
@PaulC91 I pushed one commit with fixing the labels. ptal
I've added a renv.lock
to the master branch.
Date axis labels appear to be fixed but there's an issue with the daily cases/death chart now:
@PaulC91 Thank you for spotting that. This would work fine now.
Yes looking good! thanks. Can we go with "No further information available" the default table expand message?
Sure, changed already.
This is Appsilon's initial approach to app optimization.
What has changed:
highcharter::hchart
was replaced with more low-level functions and data serialization was done by custom one that is ~2.5 secs faster.Here you can see the final result: