search

epicmaxco / vuestic-ui

Vuestic UI is an open-source Vue 3 component library designed for rapid development, easy maintenance, and high accessibility. Maintained by Epicmax (@epicmaxco).
https://vuestic.dev
MIT License
3.48k stars 337 forks source link

Automated accessibility checks #2121

Closed asvae closed 2 years ago

asvae commented 2 years ago

Run accessibility automated checks agains docs and demos.

The intention is to prevent regression as well as keeping consistent quality (accessibilty-wise) for new functionality.

asvae commented 2 years ago

@aluarius would you consider that to be useful, or majority of accessibility work requires manual tinkering?

aluarius commented 2 years ago

Only keyboard accessibility needs manual tinkering.

For aria-attributes checks we can use https://github.com/dequelabs/axe-core (refs: https://www.deque.com/blog/writing-automated-tests-accessibility/ , https://www.telerik.com/blogs/the-need-for-automated-accessibility-testing) or one of its child scripts: https://github.com/nickcolley/jest-axe , https://github.com/vue-a11y/vue-axe

aluarius commented 2 years ago

I don't think we need to integrate it as a part of release script because it's just an another one type of code testing. We can join this work with writing components tests.

m0ksem commented 2 years ago

We can write accessibility tests as well as unit tests.

We need to make these checks on commit, not release.

Let's make this task in scope of https://github.com/epicmaxco/vuestic-ui/issues/1685