epicmaxco / vuestic-ui

Free and Open Source UI Library for Vue 3 🤘
https://vuestic.dev
MIT License
3.34k stars 324 forks source link

Transfering docs to Tailwind #2838

Closed aluarius closed 1 year ago

aluarius commented 1 year ago

Related: #2816

Description

No need to check hundreds of changed files in docs/src, because there're lots of similar changes (mt-4 -> mt-6 etc).

New values are not identical to old ones, because tailwind uses 4-divisible scale, unlike ours. So, some padding-margins were changed from 12.8px to 12px for example. I've not mentioned any meaningfull artefacts on the site because of this, but better take a look twice.

Types of changes

aluarius commented 1 year ago

Why gird is commented, but not removed?

Just to be able to return them any moment. We call totally remove them in 1/6/0, i guess. Will add a comment.

aluarius commented 1 year ago

Also, it sucks now that demo can not be simply copy/pasted :(

Don't worry, this helpers were used (for about 90 percents ) in purpose of spacings between different demos :)

rustem-nasyrov commented 1 year ago
image

Margin class didn't apply here.

rustem-nasyrov commented 1 year ago
image image

Missing button color in the landing page.

rustem-nasyrov commented 1 year ago
image

Bigger indents then on the vuestic.dev

rustem-nasyrov commented 1 year ago

@xx13 is it ok to you if the code fonts will be like this?

In the PR: image Prod: image
rustem-nasyrov commented 1 year ago
https://vuestic.dev/en/ui-elements/date-input#mode image https://vuestic.dev/en/ui-elements/date-picker#mode image
rustem-nasyrov commented 1 year ago

Switch. Same on prod.

image
rustem-nasyrov commented 1 year ago
Scroll container Horizontal scroll doesn't work. image
rustem-nasyrov commented 1 year ago
Split image
Affix image Translation and bottom affix doesn't work.
Progress bar All demos are broken. image
xx13 commented 1 year ago

prod version with smaller font size looks better

@xx13 is it ok to you if the code fonts will be like this?

In the PR: image Prod: image
aluarius commented 1 year ago

Thanks, @rustem-nasyrov !

All problems listed above (including font issue) were caused by conflicts of reset files (i've disabled Tailwind's one) and flex helper (it's really display: flex for Tailwind, but display: block for Vuestic helpers %).

rustem-nasyrov commented 1 year ago
Switch image image
Split If it's not difficult for you, could you fix it as well? image
date-input#view Different paddings. image
Icons config image
aluarius commented 1 year ago

This (https://user-images.githubusercontent.com/29167241/211571987-9867982e-19bb-40cf-84bb-d46ac337bd7f.png) isn't related to this pr. I know the way to fix it, but awaiting response from Maxim.

rustem-nasyrov commented 1 year ago

This (https://user-images.githubusercontent.com/29167241/211571987-9867982e-19bb-40cf-84bb-d46ac337bd7f.png) isn't related to this pr. I know the way to fix it, but awaiting response from Maxim.

You need to apply align-items: flex-start styles and it will be fixed.

image
aluarius commented 1 year ago

You need to apply align-items: flex-start styles and it will be fixed

Yea, but it doesn't solve initial bug with the component.

aluarius commented 1 year ago

Switch problem moved to https://github.com/epicmaxco/vuestic-ui/issues/2864