va-tabs should support items

epicmaxco / vuestic-ui

Vuestic UI is an open-source Vue 3 component library designed for rapid development, easy maintenance, and high accessibility. Maintained by Epicmax (@epicmaxco).

https://vuestic.dev

MIT License

3.52k stars 341 forks source link

va-tabs should support items #285

Open asvae opened 4 years ago

asvae commented 4 years ago

See tabs items in vuetify. https://vuetifyjs.com/en/components/tabs/

Issue need investigation prior to implementation.

asvae commented 2 years ago

Not sure what I meant here, so not sure how valuable this is.

m0ksem commented 2 years ago

We need some scrollable container that can be used as TabItems. For example

<va-tabs>
   <va-tab> First </va-tab>
   <va-tab> Second </va-tab>

   <va-tab-item> First content! </va-tab-item>
   <va-tab-item> Second content! </va-tab-item>
</va-tabs>

Implementation for scrollable container (va-tab-items) can be took from va-carousel PR#1432

asvae commented 2 years ago

@m0ksem could you champion this one on grooming?

asvae commented 2 years ago

Current implementation didn't really account for content. So I'm not completely sure it needs it at all.

If it does - we have to be careful to gently meld both approaches.