epicmaxco / vuestic-ui

Vuestic UI is an open-source Vue 3 component library designed for rapid development, easy maintenance, and high accessibility. Maintained by Epicmax (@epicmaxco).
https://vuestic.dev
MIT License
3.45k stars 338 forks source link

Algolia search doesn't work properly #3039

Closed kushich closed 1 year ago

kushich commented 1 year ago

We decided to use #3425 approach instead

In context of this task please only do enough to make search work. There is no need to go through all examples and remove translations completely.


Algolia doesn't show some pages. I know that it takes some time to refresh its data after updates but we can't find even a scroll container component which we have for a long time.

Child issues: Closes https://github.com/epicmaxco/vuestic-ui/issues/2691 Closes https://github.com/epicmaxco/vuestic-ui/issues/2645

Also see #3363

rustem-nasyrov commented 1 year ago

Waiting for migration docs to the another hosting.

rustem-nasyrov commented 1 year ago

Pages are crawled, except few ones.

misterpekert commented 1 year ago

The configuration of Algolia to support multilanguage search is not easily implemented with indices built by the Algolia crawler. We should either consider providing a custom config for Algolia (sitemap with specific language for each page) and pass user language as a query to Algolia or have a separate index for each language. We can do so, as all localized pages are split by the lang prefix in the URL. After that, we would change the Algolia search index depending on the user's language in the doc settings. 2nd approach is more robust, but it'd be a problem to maintain (and support new languages). Or we can drop translation support, stick to the English-only version, and reconsider this decision when necessary.

m0ksem commented 1 year ago

The configuration of Algolia to support multilanguage search is not easily implemented with indices built by the Algolia crawler. We should either consider providing a custom config for Algolia (sitemap with specific language for each page) and pass user language as a query to Algolia or have a separate index for each language. We can do so, as all localized pages are split by the lang prefix in the URL. After that, we would change the Algolia search index depending on the user's language in the doc settings. 2nd approach is more robust, but it'd be a problem to maintain (and support new languages). Or we can drop translation support, stick to the English-only version, and reconsider this decision when necessary.

Dropping translation support is the solution. At least for now.

asvae commented 1 year ago

Fixed in 323a24a18538481f206471a66b5d24d5d83d413f

It was hard to do in pull request (algolia only crawled ui.vuestic.dev), so hacked everything in master 🥷.