search

epicmaxco / vuestic-ui

Vuestic UI is an open-source Vue 3 component library designed for rapid development, easy maintenance, and high accessibility. Maintained by Epicmax (@epicmaxco).
https://vuestic.dev
MIT License
3.52k stars 340 forks source link

Dark mode in SSG #3395

Open m0ksem opened 1 year ago

m0ksem commented 1 year ago

Because we render components colors in absolute values, not in css variables - it is impossible to have good dark theme in SSG... Need to change useColors() rendrering.

Details:

VaSidebar background renders now as #ffffff (e.g. absolute color by getColor()). We need it to be a css variable, so when page renders in SSG, css variable will change its color to dark in dark mode.

The problem here is dealing with colors like rgba(255, 255, 255, 0.5). We might need to have "raw" css variables like va-primary-raw and use it on sidebar item bg as background: rgba(var(--va-primary-raw. 0.5).

It is huge amount of work and I'm not sure if people use Vuestic in SSG right now. So we let it be on hold.

asvae commented 1 year ago

This is not too critical. So we can leave this issue until we have more time.