search

epicmaxco / vuestic-ui

Free and Open Source UI Library for Vue 3 🤘
https://vuestic.dev
MIT License
3.33k stars 323 forks source link

VaDatePicker a11y #3747

Open Roman4437 opened 9 months ago

Roman4437 commented 9 months ago

closes #3744

added essential roles and attributes

m0ksem commented 9 months ago

I checked out that gridcell must be used in row. It is a requirement, otherwise gridcell will not be recognized. We're using css grid here, so we don't have an actual row element...

I think we need to change component layout from css grid, to more general approach with row

roles:

grid
  row
     columnheader <- weekdays
  rowgroup
     row
       gridcell <- date

What if we make VaGrid component, which will implement all of these with keyboard navigation? I think it might be useful for people who make something like cinema chair picker or whatever requires navigation with grid. We could reuse VaGrid in DatePicker. I think for this PR we can simply remove wrong roles and implement VaGrid component later.