search

epicmaxco / vuestic-ui

Vuestic UI is an open-source Vue 3 component library designed for rapid development, easy maintenance, and high accessibility. Maintained by Epicmax (@epicmaxco).
https://vuestic.dev
MIT License
3.46k stars 339 forks source link

Set specific width for modal #3972

Open m0ksem opened 11 months ago

m0ksem commented 11 months ago 
          We'll need to update sizesConfig and change how this whole thing works, because right now you're not able to set specific width for modal.

Originally posted by @m0ksem in https://github.com/epicmaxco/vuestic-ui/issues/3961#issuecomment-1770117040

xiongmao86 commented 11 months ago

I am sorry to submit an immature pr that works temporarily and doesn't actuary solve the problem. I am sorry for wasting your time.

m0ksem commented 11 months ago

I am sorry to submit an immature pr that works temporarily and doesn't actuary solve the problem. I am sorry for wasting your time.

Everything is fine! It is actually a separate feature request in addition to bug fix you made ❤️.

We have poor implementation of sizes config which comes from long time ago. Reworking it will help us make better size configs, support absolute values like px, rem, etc. It is planned for feature.

xiongmao86 commented 11 months ago

Thank you very much, @m0ksem, I am relief. I am a terrible emotion reader, I kept worrying offend people without notice another time.

dejanadamovic commented 10 months ago

Is there a workaround to set width of modal?

m0ksem commented 10 months ago

Is there a workaround to set width of modal?

You can use custom class on <VaModal class="my-modal" /> and set width for ..va-modal__dialog and .va-modal__inner using CSS. Or apply it to va-modal class globally.