search

epics-base / ci-scripts

Continuous Integration Scripts for EPICS Modules
Other
8 stars 18 forks source link

Formatfix #12

Closed dirk-zimoch closed 4 years ago

dirk-zimoch commented 4 years ago

Fix for issue #11

ralphlange commented 4 years ago

Thanks a lot! Duh - I remember I had those fixes in ... must have dropped them in one of my commit rearranging efforts.

dirk-zimoch commented 4 years ago

I just noticed that I missed the error message in utils.sh. Lines 43, 80, 150, 194. They need -e as well.

dirk-zimoch commented 4 years ago

What about a function ?

die() {
  echo -e "${ANSI_RED}$1${ANSI_RESET}"
  [ "$UTILS_UNITTEST" ] || exit 1
}
ralphlange commented 4 years ago

Looks good. Isn't that how it's done? (Another change that I did and lost during my reorganization?)

ralphlange commented 4 years ago

Oh, in the other script. I see. Yes, that's a good idea! Happy to merge more commits to your branch if you have time to work on this. Otherwise I will do these changes next week.

dirk-zimoch commented 4 years ago

See merge request #13.