epics-base / ci-scripts

Continuous Integration Scripts for EPICS Modules

Other

8 stars 18 forks source link

Don't use bash 4 substitions for upper/lowercase conversions #26

Closed tboegi closed 4 years ago

tboegi commented 4 years ago

Some bash-istic parameter expansion is used to convert upper-lower case or vice versa. This does not work under bash 3.0, which is default on MacOs boxes. Use tr instead.

ralphlange commented 4 years ago

See 80ab304. This handled by the scripts (that install a newer Bash on MacOS).

tboegi commented 4 years ago

The installation doesn't work on non-travis-systems that use MacPorts :-(

Anyway, is there an idea how to fix https://github.com/epics-base/ci-scripts/issues/16

ralphlange commented 4 years ago

I am sorry, but travis scripts not working on non-travis systems that are different is not the highest priority.

Bash 4 was released in 2009. The reason that Apple ships an older version is that their company policy does not allow including software under GPLv3 (more background). I am not willing to restrict new developments to 10 year old tools because of that company's policy.

16 is a reminder to remove a compatibility code block that is in the script with the next major update. (As major updates are allowed to break compatibility.) It not something that has to be fixed.

ralphlange commented 4 years ago

I'd be willing to change things that organize the necessary updates using MacPorts instead of Homebrew to allow local debugging, though. I also added the Bash 4 requirement to the README (f92c1e71)

tboegi commented 4 years ago

Probably I need to prepare a new patch - within the next days.

ralphlange commented 4 years ago

ci-scripts 3.0.0 is entirely python and will not use bash scripts anymore. Closing as invalid.