search

epics-base / ci-scripts

Continuous Integration Scripts for EPICS Modules
Other
8 stars 18 forks source link

Clear empty environment variables #57

Closed mdavidsaver closed 4 years ago

mdavidsaver commented 4 years ago

Github actions configuration doesn't provide a way to conditionally set/unset environment variables. So conditional variables end up set with an empty value. Unfortunately cue.py treats unset and empty variables differently.

Rather than (or ahead of) a comprehensive change to replace all of the if <var> in os.environ, @ralphlange suggests to simply unset all empty environment variables.

This certainly could have side-effects, but based on my testing, this isn't the case for github actions or appveyor.

ralphlange commented 4 years ago

Yep, that's good enough until GH adds unsetting variables. (If they do.)