epics-base / jca

Java Channel Access client API
https://www.javadoc.io/doc/org.epics/jca/latest/index.html
Other
8 stars 14 forks source link

Remove sychronized keyword to avoid deadlock #33

Closed slominskir closed 5 years ago

slominskir commented 5 years ago

See https://github.com/epics-base/jca/issues/32

shroffk commented 5 years ago

Thanks...I will merge this once I get the travis CI to build this PR i am not sure why it hasn't done so automatically already

krisztianloki commented 4 years ago

Hi, does this mean that this comment in CAJChannel.destroyChannel() no longer applies?

        {
            if (transport != null)
            {
                try
                {
                    // NOTE: this does not submit message immediately, waits for flush to be triggered somehow.. hmmm.
                    // possible deadlock if sent immediately (since lock on this channel instance is held)
                    new ClearChannelRequest(transport, channelID, serverChannelID).submit();
                }
                catch (IOException ioex)
                {