search

epics-base / jca

Java Channel Access client API
https://www.javadoc.io/doc/org.epics/jca/latest/index.html
Other
8 stars 14 forks source link

Switch from Travis-CI to GitHub Actions #66

Closed ralphlange closed 2 years ago

ralphlange commented 2 years ago

ssia

ralphlange commented 2 years ago

I think this is ready now...

ralphlange commented 2 years ago

Java 16 is an intentionally ignored (for now) failure (see #67). The site building job intentionally only runs for the master branch - skipping it on a pull request is expected.

shroffk commented 2 years ago

@ralphlange should we just skip jdk16 for the time being ( we keep the issue ticket open to document all that you have done )

ralphlange commented 2 years ago

Your call.

I configured it to not fail the build and kept it so we always have it on our radar that there is an issue to be fixed. If you prefer not to see that - fine with me.

shroffk commented 2 years ago

Could you comment out the jdk16 inclusion - this was the comments remain in place as a reminder but the CI for the main project appears green. I can't updated your branch so I am pushing this back to you :) Thanks again

ralphlange commented 2 years ago

I don't understand.

Again: I added the configuration to have that job not fail the build. I.e., the CI for the main project appears green even though the Java 16 build is failing. (See https://github.com/ralphlange/jca/actions/runs/2703430640 for an example.)

shroffk commented 2 years ago

the thing is all PR's will have the "some failing" bit... which is what I was referring to. In anycase...I have merged it for the time being... if it causes confusion with future PR's then it I will go and comment it out. Thanks!

ralphlange commented 2 years ago

Thanks! I'm fine with hiding the failures should they cause confusion. (I would still rather have them fixed than hidden.)